Feature #373

avatar

PHP Strict Standards

Added by Shish Moom 194 days ago. Updated 168 days ago.

Status:Resolved Start:
Priority:Low Due date:
Assigned to:- % Done:

0%
Category:core
Target version:2.3

Description

Turn on strict logging and read php log

PHP Strict Standards:  is_a(): Deprecated. Please use the instanceof operator in /var/www/ponos.net/htdocs/shimmie/ext/image/main.php on line 46
PHP Strict Standards:  Declaration of ADORecordSet_array::FetchField() should be compatible with that of ADORecordSet::FetchField() in /var/www/ponos.net/htdocs/shimmie/lib/adodb/adodb.inc.php on line 3709
PHP Strict Standards:  Only variables should be assigned by reference in /var/www/ponos.net/htdocs/shimmie/lib/adodb/adodb.inc.php on line 824

every page hit is over9000 lines in the log.

History

Updated by Shish - 194 days ago

avatar
  • Status changed from New to Closed
  • 1 set to worksforme

is_a was used in older shimmies because PHP4 doesn't have instanceof; 2.3 and onwards are PHP5 only, and use the PHP5 functions. (If you do spot some old PHP4 code in 2.3+, that's a bug~)

Adodb problems should be reported to the adodb author, I'm just using the library from there, and would rather avoid having to maintain a customised version.

If turning on extra warning messages for things that aren't bugs is majorly annoying, don't turn them on? :-P (Normally I have everything set to strictest with all warnings turned on, but PHP is special, because it's actually impossible to write code which runs warning-free in all versions _;;)

Updated by Shish Moom 194 days ago

avatar
After clicking on a tag.
[10-May-2009 23:50:06] PHP Warning:  Missing argument 2 for SearchTermParseEvent::SearchTermParseEvent(), called in /var/www/ponos.net/htdocs/shimmie/core/imageboard.pack.php on line 501 and defined in /var/www/ponos.net/htdocs/shimmie/ext/index/main.php on line 11 
[10-May-2009 23:50:06] PHP Notice:  Undefined variable: context in /var/www/ponos.net/htdocs/shimmie/ext/index/main.php on line 13 
[10-May-2009 23:50:06] PHP Warning:  Missing argument 2 for SearchTermParseEvent::SearchTermParseEvent(), called in /var/www/ponos.net/htdocs/shimmie/core/imageboard.pack.php on line 501 and defined in /var/www/ponos.net/htdocs/shimmie/ext/index/main.php on line 11 
[10-May-2009 23:50:06] PHP Notice:  Undefined variable: context in /var/www/ponos.net/htdocs/shimmie/ext/index/main.php on line 13

Updated by Shish Moom 194 days ago

avatar
  • Status changed from Closed to Feedback
  • 1 deleted (worksforme)
[11-May-2009 01:37:49] PHP Fatal error:  Using $this when not in object context in /var/www/ponos.net/htdocs/shimmie/core/imageboard.pack.php on line 589

Updated by Shish - 193 days ago

avatar

These should be fixed in git / svn / 2.3-beta3, along with a bunch of other misc things

Updated by Shish Moom 168 days ago

avatar
  • Status changed from Feedback to Resolved
  • Assigned to deleted (Shish -)

Things seem ok now

Also available in: Atom PDF